jack/dash-api
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

refactor: clean up unused imports and improve code organization

Browse Source
This commit is contained in:
leene
2025-09-13 09:29:08 +02:00
parent 7cbf75d6a8
commit 814f88932d
3 changed files with 42 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/components/data_table.py
View File

@ -7,6 +7,15 @@ import dash_bootstrap_components as dbc
from ..data.loader_gz import MTBFSchema
from . import ids
import pandas as pd
from dash import Dash, dcc, html, dash_table, Input, Output, State, callback_context
from datetime import datetime
import os
import dash_bootstrap_components as dbc
from ..data.loader_gz import MTBFSchema
from . import ids
def render(app: Dash, data: pd.DataFrame) -> html.Div:
@app.callback(
Output(ids.DATA_TABLE, "children"),
@ -18,7 +27,7 @@ def render(app: Dash, data: pd.DataFrame) -> html.Div:
],
)
def update_data_table(
years: list[str], weeks: list[str], hits_type: str, single_hitter_filter: list[str]
years: list[str], weeks: list[str], u_hits: bool, remove_single: bool
) -> html.Div:
filtered_data = data.query(
"year in @years and week in @weeks"
@ -26,10 +35,7 @@ def render(app: Dash, data: pd.DataFrame) -> html.Div:
if filtered_data.shape[0] == 0:
return html.Div("No data selected.")
if hits_type == "p-hits":
hits_col = MTBFSchema.P_HITS
else:
hits_col = MTBFSchema.U_HITS
hits_col = MTBFSchema.U_HITS if u_hits else MTBFSchema.P_HITS
# Count 'Y' values
hits_data = filtered_data[filtered_data[hits_col] == 'Y']
@ -40,10 +46,8 @@ def render(app: Dash, data: pd.DataFrame) -> html.Div:
close_notes=(MTBFSchema.CLOSE_NOTES, lambda x: ', '.join(x.dropna().astype(str).unique()))
).reset_index()
if 'remove_single' in single_hitter_filter:
if remove_single:
table_data = table_data[table_data['count'] > 1]
else:
table_data = table_data[table_data['count'] == 1]
table_data = table_data.sort_values('count', ascending=False)
@ -51,7 +55,7 @@ def render(app: Dash, data: pd.DataFrame) -> html.Div:
table_data = table_data[[MTBFSchema.AIR, 'air_issue_description', 'close_notes', 'count']]
return dash_table.DataTable(
id=ids.CATEGORY_TABLE, # Using this ID for feedback callbacks
id=ids.MTBF_PAR_TABLE, # Using this ID for feedback callbacks
data=table_data.to_dict("records"),
columns=[{"name": i, "id": i} for i in table_data.columns],
page_size=10,
@ -64,11 +68,11 @@ def render(app: Dash, data: pd.DataFrame) -> html.Div:
@app.callback(
Output(ids.FEEDBACK_MODAL, "is_open"),
Output(ids.FEEDBACK_MESSAGE, "children"),
Input(ids.CATEGORY_TABLE, "selected_rows"),
Input(ids.MTBF_PAR_TABLE, "selected_rows"),
Input(ids.SAVE_FEEDBACK_BUTTON_POPUP, "n_clicks"),
Input(ids.CLOSE_FEEDBACK_BUTTON_POPUP, "n_clicks"),
State(ids.FEEDBACK_MODAL, "is_open"),
State(ids.CATEGORY_TABLE, "data"),
State(ids.MTBF_PAR_TABLE, "data"),
State(ids.FEEDBACK_INPUT, "value"),
)
def handle_feedback_modal(selected_rows, save_clicks, close_clicks, is_open, table_data, comment):
@ -78,7 +82,7 @@ def render(app: Dash, data: pd.DataFrame) -> html.Div:
triggered_id = ctx.triggered[0]['prop_id'].split('.')[0]
if triggered_id == ids.CATEGORY_TABLE and selected_rows:
if triggered_id == ids.MTBF_PAR_TABLE and selected_rows:
return True, ""
if triggered_id == ids.SAVE_FEEDBACK_BUTTON_POPUP and selected_rows:
@ -107,8 +111,8 @@ def render(app: Dash, data: pd.DataFrame) -> html.Div:
@app.callback(
Output("feedback-category-label", "children"),
Input(ids.CATEGORY_TABLE, "selected_rows"),
State(ids.CATEGORY_TABLE, "data"),
Input(ids.MTBF_PAR_TABLE, "selected_rows"),
State(ids.MTBF_PAR_TABLE, "data"),
prevent_initial_call=True
)
def update_feedback_air_label(selected_rows, data):